-
Notifications
You must be signed in to change notification settings - Fork 1.4k
tests: zephyr: drivers: Enable driver tests on LV10 NS part 1 #25103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: zephyr: drivers: Enable driver tests on LV10 NS part 1 #25103
Conversation
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 05624a78e031b482c5a58ad6579ce30cef750831 more detailssdk-nrf:
Github labels
List of changed files detected by CI (10)Outputs:ToolchainVersion: 46667c6630 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
Works in CI: |
|
nrf.extended.drivers.clock.nrf_lf_clock_start_xtal_no_wait has to be quarantined |
ead1be7 to
fbacbd3
Compare
fbacbd3 to
f821576
Compare
| nrf54lv10dk/nrf54lv10a/cpuapp: | ||
| append: | ||
| EXTRA_DTC_OVERLAY_FILE: boards/nrf54lv10dk_nrf54lv10a_cpuapp.overlay | ||
| nrf54lv10dk/nrf54lv10a/cpuapp/ns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abuse of snippets, remove this and use board overlays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directory tests/zephyr/* contains tests copied from upstream Zephyr.
We use them to verify "unofficial" platforms like nrf54lv10, nrf54ls05, nrf7120, etc.
We do that by adding overlays and extending platform_allow list.
Idea is to apply identical changes to samples/tests when the target is upstreamed.
I can change this to use overlays, but when LV10 is pushed to the upstream Zephyr, it will be discarded because this test in the upstream uses code snippets:
https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/drivers/comparator/gpio_loopback/snippets/nrf_comp/boards
Therefore, unless upstream test is modified, this request demands work that will ultimately be discarded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to tight schedule, I propose to merge this as is.
I created task NRFX-8570 to rework the comparator with gpio loopback test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is another variant of #24430 (comment)
Why is it better to keep wrong behavior now, and then have two follow-up PRs, one ins sdk-nrf and later upstream Zephyr, instead of doing it correct here, and then do only one followup PR upstream afterwards ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have time for such cleaning now. It was not planned. We are just before new product launch thus we focus on testing not refactoring.
Beside any work which is not coordinated with upstream cause more problem that is solves - we have then problems doing fromlist/fromtree when downstream is not aligned, as commit check fails.
I do not see point doing any refactor here and now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix.
Ref: zephyrproject-rtos/zephyr#97986
f821576 to
7b4fbd7
Compare
7b4fbd7 to
bc1ebad
Compare
bc1ebad to
2402596
Compare
|
Works in CI: |
Enable comparator test on nrf54lv10dk/nrf54lv10a/cpuapp/ns. Signed-off-by: Sebastian Głąb <[email protected]>
2402596 to
05624a7
Compare
Enable comparator test on nrf54lv10dk/nrf54lv10a/cpuapp/ns.
Enable clock_control tests on nrf54lv10dk/nrf54lv10a/cpuapp/ns.
Enable kernel/timer_behavior on nrf54lv10dk/nrf54lv10a/cpuapp/ns.